Merge kwargs for fit and deploy Sagemaker methods #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
the
safe to test
Contributor
|
Thanks for the contrib! Overall it looks good to me. I think the lint is failing, once the tests are passing (except for cluster test which is failing on master), I think we can merge. |
Author
|
@suzhoum Thanks for the review! Please proceed with merge should you have some time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #182
Description of changes: Merge the arguments to avoid double-defining properties like
role(as an argument and as kwarg).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.